Remove concurrent.futures deadcode: process_result_item()#109906
Merged
vstinner merged 1 commit intopython:mainfrom Sep 26, 2023
Merged
Remove concurrent.futures deadcode: process_result_item()#109906vstinner merged 1 commit intopython:mainfrom
vstinner merged 1 commit intopython:mainfrom
Conversation
process_result_item() cannot be called with an int anymore, the protocol changed.
Member
Author
|
result_item cannot be an int, otherwise the line after process_result_item() failed, since an int doesn't have an exit_pid attribute: self.process_result_item(result_item)
process_exited = result_item.exit_pid is not None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
process_result_item() cannot be called with an int anymore, the protocol changed.